-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update template so you can find it under Windows as well #2484
Conversation
WinUI is misleading, as this is a MAUI app, and WinUI is just an underlying tech. As a user I'd prefer keeping the WinUI section for actual WinUI apps.
Should it say both WinUI and MacCatalyst? It's not purely an implementation detail in the sense that you can (and possibly might) write code that is WinUI-specific in that app. Similarly, what about |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
@dotMorten your idea seems quite reasonable to me. |
I think that list needs to be organised. You might want to filter by WinUI as that is the tech you want to use. Or the Mac Catalyst. That is different to macOS. Both are macOS, but maccat is a subset. I suppose the argument for WinUI is that UI kit should be there too. The last drop down is project type and not platform. @lutzroeder What should we do here? Do we have some set of things? I see Plugin and Other which makes me things everyone just puts what they want willy nilly. |
Is it possible to have both, and add |
@BretJohnson is there a limit to the classifications a template can have? Is there any guidance on best practices here? |
Instead of putting Windows in the classifications, which would cause it to show up as a "project type" (third combo in VS) rather than as a platform (the second one), it should be added to the ide.host.json as follows:
If we want it to show up as "Windows" in the CLI dotnet new list, you could also add it as a classification in template.json but then do the following in the host file to "move" it to the proper drop down within VS:
|
In regards to my last comment, it looks like the IDE is doing some fix up when the VS template engine host passes what the IDE knows to be are "platforms" in as projectTypes. instead of adding it to the projectType drop down, it just treats the template as though it specified that platform tag instead. This also has the side effect of moving where the tag appears in the template detail. For example, when using @dotMorten's technique: |
Description of Change
When you filter project templates by Windows, it's almost as if MAUI isn't supported:
You have to select
All platforms
to see it, however it still works to filter by iOS, Android and MacOS, so this is inconsistent.Also the
WinUI
category is misleading, as this is a MAUI app, and WinUI is just an underlying tech. As a user I'd prefer keeping the WinUI section for actual WinUI apps, and not get the groups too polluted.PR Checklist
Does this PR touch anything that might affect accessibility?
If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.