Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workload] rename Microsoft.Maui.Controls.Sdk #2502

Conversation

jonathanpeppers
Copy link
Member

Description of Change

It is a bit confusing the top level Sdk pack for the Maui workload is
named Microsoft.Maui.Controls.Sdk. This pack is imported even when
you're not using "Controls", such as $(UseMauiCore),
$(UseMauiAssets), etc.

Let's rename:

  • Microsoft.Maui.Controls.Sdk -> Microsoft.Maui.Sdk
  • Microsoft.Maui.Controls.Sdk.targets -> Microsoft.Maui.Sdk.targets
  • Microsoft.Maui.Controls.Sdk.After.targets -> Microsoft.Maui.Sdk.After.targets

This change should hopefully be transparent to everyone, and no one
will notice?

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

No

It is a bit confusing the top level Sdk pack for the Maui workload is
named `Microsoft.Maui.Controls.Sdk`. This pack is imported even when
you're not using "Controls", such as `$(UseMauiCore)`,
`$(UseMauiAssets)`, etc.

Let's rename:

* `Microsoft.Maui.Controls.Sdk` -> `Microsoft.Maui.Sdk`
* `Microsoft.Maui.Controls.Sdk.targets` -> `Microsoft.Maui.Sdk.targets`
* `Microsoft.Maui.Controls.Sdk.After.targets` -> `Microsoft.Maui.Sdk.After.targets`

This change should hopefully be transparent to everyone, and no one
will notice?
@jonathanpeppers jonathanpeppers marked this pull request as ready for review September 16, 2021 15:51
@jonathanpeppers
Copy link
Member Author

@pjcollins to just double-check this won't break VS insertions to rename a pack.

Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all the spots were changed.

Nice to get accurate names!

Copy link
Member

@pjcollins pjcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe this will cause any issues wrt VS insertion.

@jonathanpeppers jonathanpeppers merged commit 66cc324 into dotnet:main Sep 16, 2021
@jonathanpeppers jonathanpeppers deleted the rename-microsoft.maui.controls.sdk branch September 16, 2021 21:12
@Redth Redth added this to the 6.0.101-preview.9 milestone Sep 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants