Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android] bump to Xamarin.Android.Glide 4.12.0.2 #2563

Merged
merged 1 commit into from Sep 17, 2021

Conversation

jonathanpeppers
Copy link
Member

Description of Change

Context: xamarin/XamarinComponents@a245afa
Context: https://www.nuget.org/packages/Xamarin.Android.Glide/4.12.0.2

The latest version of Xamarin.Android.Glide includes .NET 6 packages. .NET MAUI should use this version.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

No

Did some manual testing, images still display with dotnet new maui:

image

Context: xamarin/XamarinComponents@a245afa
Context: https://www.nuget.org/packages/Xamarin.Android.Glide/4.12.0.2

The latest version of Xamarin.Android.Glide includes .NET 6 packages. .NET MAUI should use this version.
@jonathanpeppers jonathanpeppers marked this pull request as ready for review September 17, 2021 15:49
@PureWeen PureWeen merged commit be4ab30 into dotnet:main Sep 17, 2021
@jonathanpeppers jonathanpeppers deleted the glide-4.12.0.2 branch September 17, 2021 16:31
@Redth Redth added this to the 6.0.101-preview.9 milestone Sep 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants