-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi Window Support #2811
Merged
Merged
Multi Window Support #2811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's missing from lifecycle events (if it's available there natively?), workaround this for now.
mattleibow
reviewed
Oct 1, 2021
iOS just needs to be cleaned up now
mattleibow
approved these changes
Nov 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
legacy-area-desktop
Windows / WinUI / Project Reunion & Mac Catalyst / macOS specifics (Menus & other Controls))
t/desktop
The issue relates to desktop scenarios (MacOS/MacCatalyst/Windows/WinUI/WinAppSDK)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for opening multiple windows on all the platforms that support them:
API Usage
The usage of the API is pretty simple:
API Implementation
This API is implemented in the
ApplicationHandler
and uses a"OpenWindow"
command withOpenWindowRequest
arguments to hold state and launch options.When a window is closed/backgrounded, there is a new
Backgrounding
event onWindow
that can be used to persist any string state to an object that the OS will preserve until it is time to resume that window. An example of state would be maybe a document path that the user has opened.Then at some point in the future, when the user selects that window to resume, the state is provided via the
IActivationState
inCreateWindow
. This state can the be read and used to re-load that document (if it is still available).