Remove references to an "app window" #3003
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Remove the "app window" references on app objects. Not only is this a bit confusing in multi-window scenarios, we can now make use of the
Application.Windows[x].Handler.NativeView
to get the actual window.Anything not in that list of windows has no native window nor handler yet and thus would not be found anyway.
A benefit of not looking on the Maui* objects for properties is that any activity/window type can be used (maybe from a 3rd party) and it is all linked via the handler.
Additions made
MainWindow
andVirtualWindow
propertiesPR Checklist
Does this PR touch anything that might affect accessibility?
If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.