[build] Add maui-blazor to vs-workload.props #3105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `@(ComponentResources)` item in the vs-workload.props file is used by the [`<GenerateVisualStudioWorkload/>` task][0] to fill out missing information when generating Visual Studio installer manifests for Mauis .NET workloads. Whenever a new workload is added to the [`WorkloadManifest.json` file][1], a corresponding entry must be added to `vs-workload.template.props` or the generated VS manifests will contain incomplete information. [0]: https://github.com/dotnet/arcade/blob/5aa9d32c0fd7f412ea60aba2b9650fcbd3b8766c/src/Microsoft.DotNet.Build.Tasks.Workloads/src/GenerateVisualStudioWorkload.cs#L18 [1]: https://github.com/dotnet/maui/blob/ed9088699a589a8dfdd3ad6f2c0d36a16d270380/src/Workload/Microsoft.NET.Sdk.Maui/WorkloadManifest.in.json
Eilon
added
area-blazor
Eilon
requested changes
Oct 25, 2021
Co-authored-by: Eilon Lipton <Eilon@users.noreply.github.com>
Redth
approved these changes
Oct 25, 2021
mattleibow
approved these changes
Oct 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@(ComponentResources)item in the vs-workload.props file is usedby the
<GenerateVisualStudioWorkload/>task to fill out missinginformation when generating Visual Studio installer manifests for Mauis
.NET workloads. Whenever a new workload is added to the
WorkloadManifest.jsonfile, a corresponding entry must be addedto
vs-workload.template.propsor the generated VS manifests willcontain incomplete information.