Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS Navigation #3467

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Fix iOS Navigation #3467

merged 1 commit into from
Nov 19, 2021

Conversation

PureWeen
Copy link
Member

Description of Change

Legacy Navigation is currently firing off the handler navigation path which is queueing a navigation task that never gets fulfilled. This PR checks to see if Navigation should be following a shimmed vs MAUI path and then correctly exits or continues.

@PureWeen PureWeen enabled auto-merge (squash) November 19, 2021 15:30
@PureWeen PureWeen merged commit 0365098 into main Nov 19, 2021
@PureWeen PureWeen deleted the nav_unittests branch November 19, 2021 16:39
@samhouts samhouts added area-navigation NavigationPage area-controls-pages Page types labels Jul 11, 2023
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@Eilon Eilon removed legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor area-controls-pages Page types labels May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-navigation NavigationPage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants