Trigger frame events when the frame changes #3521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
added
the
area-layout
jsuarezruiz
approved these changes
Nov 29, 2021
hartez
approved these changes
Nov 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
At some point in the past, we no longer triggered the
Frameproperty and then command, so certain updates were not propagated.This PR makes sue that when
NativeArrangeis called and updates the native view, it triggers theFramecommand which in turn allows the ViewHandlers to update things like transforms, shadows and backgrounds.On iOS, this gave rise to the case where if the transforms were set in the XAML, then they would reach the handler before the first layout event. This meant that the width/height would still be -1 and the transforms would be skipped. Then, when the layout happened, the transforms would not be calculated.