Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Changes to improve Border control drawing performance #3620

Merged
merged 2 commits into from
Jan 13, 2022

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Changes to improve Border control drawing performance on Android. Changes:

  • Validations to avoid invalidate the Border if is not neccesary.
  • Simplified the Border Drawable Draw method.

issue-border-perf-01

And with other sample using virtualization.

(NOTE: Left emulator is using Preview 10, and the right one this branch)

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

Does this PR touch anything that might affect accessibility?

  • No

@jsuarezruiz jsuarezruiz added t/bug Something isn't working platform/android 🤖 area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing legacy-area-perf Startup / Runtime performance labels Dec 2, 2021
@jsuarezruiz
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jsuarezruiz
Copy link
Contributor Author

@hartez With the second sample a big part of the time is with Layouts (OnLayout, OnMeasure). We can merge this PR, but, after that could we share some time reviewing what's happening at Layout level to try to improve more?

@hartez
Copy link
Contributor

hartez commented Dec 16, 2021

@hartez With the second sample a big part of the time is with Layouts (OnLayout, OnMeasure). We can merge this PR, but, after that could we share some time reviewing what's happening at Layout level to try to improve more?

Sure.

@jsuarezruiz jsuarezruiz merged commit 516fe30 into main Jan 13, 2022
@jsuarezruiz jsuarezruiz deleted the fix-border-perf-droid branch January 13, 2022 16:46
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2023
@Eilon Eilon added t/perf The issue affects performance (runtime speed, memory usage, startup time, etc.) and removed legacy-area-perf Startup / Runtime performance labels May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing platform/android 🤖 t/bug Something isn't working t/perf The issue affects performance (runtime speed, memory usage, startup time, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants