Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS set UserInteractionEnabled to true when adding gestures #3623

Merged
merged 5 commits into from
Dec 2, 2021

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Dec 2, 2021

Description of Change

In XF the default was to set UserInteractionEnabled to true on every single element. With Maui we haven't implemented InputTransparent yet so the logic for setting UserInteractionEnabled hasn't been figured out for MAUI as of yet.

This PR does the minimum required to correctly set UserInteractionEnabled if a user has added GestureRecognizers. Once we implement InputTransparent then the value of UserInteractionEnabled should all get calculated inside the InputTransparent mappers

Additions made

  • Adds

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the WinUI, Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

  • Does this PR introduce a new control? (If yes, add an example using SemanticProperties to the SemanticsPage)
  • APIs that modify focusability?
  • APIs that modify any text property on a control?
  • Does this PR modify view nesting or view arrangement in anyway?
  • Is there the smallest possibility that your PR will change accessibility?
  • I'm not sure, please help me

If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.

@PureWeen PureWeen enabled auto-merge (squash) December 2, 2021 17:16
@jsuarezruiz jsuarezruiz added the area-xaml XAML, CSS, Triggers, Behaviors label Dec 2, 2021
@PureWeen PureWeen merged commit c682650 into main Dec 2, 2021
@PureWeen PureWeen deleted the ios_fix_gestures branch December 2, 2021 18:34
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2023
@Eilon Eilon added area-gestures Gesture types and removed area-xaml XAML, CSS, Triggers, Behaviors labels May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-gestures Gesture types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TapGestureRecognizer doesn't call Tap handler when used in a DataTemplate [Bug] Tap Gesture ios and MAC
3 participants