Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clip layouts to bounds #3709

Merged
merged 6 commits into from
Jan 18, 2022
Merged

Clip layouts to bounds #3709

merged 6 commits into from
Jan 18, 2022

Conversation

hartez
Copy link
Contributor

@hartez hartez commented Dec 9, 2021

Modifies the various layout backing controls to handle clipping their children to bounds when specified. Adds bool ClipsToBounds { get; } to the ILayout interface in Core. Maps the IsClippedToBounds property in Controls to ClipsToBounds.

Fixes #3554.

Also fixes a HorizontalStackLayoutManager bug, a Windows Label Opacity bug, and a Windows measurement bug I came across while fixing this.

@Eilon Eilon added the area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter label Dec 10, 2021
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could include a sample in the gallery

@hartez hartez marked this pull request as draft December 13, 2021 19:10
@hartez hartez marked this pull request as ready for review December 17, 2021 21:15
@hartez hartez added this to the 6.0.200-preview.13 milestone Dec 29, 2021
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clipping

@hartez hartez merged commit ea549b2 into main Jan 18, 2022
@hartez hartez deleted the fix-3554 branch January 18, 2022 21:03
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layouts are not clip to bounds
3 participants