-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clip layouts to bounds #3709
Merged
Clip layouts to bounds #3709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 9, 2021
jsuarezruiz
reviewed
Dec 9, 2021
jsuarezruiz
reviewed
Dec 9, 2021
Eilon
added
the
area-layout
StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter
label
Dec 10, 2021
jsuarezruiz
approved these changes
Dec 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could include a sample in the gallery
jsuarezruiz
approved these changes
Jan 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make opacity work on Labels with backgrounds on Windows Add ClipsToBounds for layouts Fixes #3554
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-layout
StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the various layout backing controls to handle clipping their children to bounds when specified. Adds
bool ClipsToBounds { get; }
to theILayout
interface in Core. Maps theIsClippedToBounds
property in Controls toClipsToBounds
.Fixes #3554.
Also fixes a HorizontalStackLayoutManager bug, a Windows Label Opacity bug, and a Windows measurement bug I came across while fixing this.