Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no longer used LaunchScreen.xib files from templates #3780

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

jfversluis
Copy link
Member

Description of Change

Removes (as far as I can tell) unused LaunchScreen.xib files from the templates as these were causing issues with the iOS archiving. See related issue.

For reference, this is what it looks like, I think this was the default splash screen for new Xamarin apps at some point?

image

Fixes #3777

Additions made

NA

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the WinUI, Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

  • Does this PR introduce a new control? (If yes, add an example using SemanticProperties to the SemanticsPage)
  • APIs that modify focusability?
  • APIs that modify any text property on a control?
  • Does this PR modify view nesting or view arrangement in anyway?
  • Is there the smallest possibility that your PR will change accessibility?
  • I'm not sure, please help me

If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.

@jfversluis
Copy link
Member Author

Is there any way to test the templates without waiting for them to be released first?

@jfversluis jfversluis added the area-templates Project templates, Item Templates for Blazor and MAUI label Dec 15, 2021
@Redth
Copy link
Member

Redth commented Dec 15, 2021

@jfversluis there's a script in the folder you can use to build the template nuget packages and then you can dotnet new -i Microsoft.Maui.Templates.xyz.nupkg to install them and dotnet new maui to test...

Just remember to dotnet new -u Microsoft.Maui.Templates after so you don't mess up your global install :)

@jfversluis jfversluis added the do-not-merge Don't merge this PR label Dec 15, 2021
@jfversluis
Copy link
Member Author

Thanks! Adding DNM until I/we verify this doesn't break anything and works when actually changed in the templates

@jfversluis
Copy link
Member Author

Tested, all seems to work fine on my end. No errors, and splash screen shows as expected. @chamons were you investigating something on your end for iOS only?

@jfversluis jfversluis removed the do-not-merge Don't merge this PR label Dec 16, 2021
@chamons
Copy link

chamons commented Dec 16, 2021

Yes, I'm hoping to confirm (or refute) that iOS has a bug today. Unfortunately I'm having major issues getting XVS remote builds with NET6 working on my PC, so I'm waiting for help on testing things (to get a binlog).

@chamons
Copy link

chamons commented Dec 16, 2021

But in any case, this PR has no issues FWICT and doesn't have to wait.

@Redth Redth merged commit 6e89bbc into main Dec 16, 2021
@Redth Redth deleted the remove-launchscreenxib branch December 16, 2021 19:46
@Thomr77
Copy link

Thomr77 commented Dec 17, 2021

Hi,

We have also encountered this issue today with a Maui-Blazor project compiling in Release to an iPhone connected to the (build) Mac (17.1.0 Preview 1.1).

We deleted LaunchScreen.xib after reading through the discussions here, but the issue persisted - the same '//' in path e.g. "obj/Release/net6.0-ios/ios-arm64//stripped/Microsoft.Extensions.DependencyInjection.Abstractions.dll".

What I can add is that it compiles fine with the above constellation but in Debug and other custom-made types (but not Release).

@jfversluis
Copy link
Member Author

@Thomr77 did you use the /p:EnableAssemblyILStripping=false flag? That is a separate bug that is fixed but not yet released. If you added that flag and it still doesn't work could you reach out on gerald.versluis@microsoft.com? Because I would love to learn more about it and see if we need more fixing in this area. Thanks!

@Thomr77
Copy link

Thomr77 commented Dec 17, 2021

@jfversluis confirming that it builds Release fine with /p:EnableAssemblyILStripping=false - Dank u!

@jfversluis
Copy link
Member Author

Awesome @Thomr77 ! Thanks for letting me know! Goed weekend! Voor zover dat gaat met een nieuwe lockdown... 😅

@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-templates Project templates, Item Templates for Blazor and MAUI t/housekeeping ♻︎
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Archiving .NET MAUI iOS apps not working
5 participants