GridLayout -> Grid to reduce confusion #3865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartez
added
proposal/open
area-layout
|
Just my own opinion, and by far not an important matter to me, but, I personally would rather have the consistency in the API and remove Grid subclass, or renaming the other "Layout" classes to their root name. |
As much as I like that suggestion, we'd end up with AbsoluteLayout -> Absolute and RelativeLayout -> Relative. |
jsuarezruiz
reviewed
Jan 13, 2022
hartez
force-pushed
the
grid-sans-layout
branch
from
071c961
to
0784388
Compare
Redth
approved these changes
Jan 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The naming of
GridLayout(and the inclusion of theGridsubclass for ease of upgrading) is causing a lot of confusion. So I'm proposing we go for clarity over consistency and simply leave the name asGrid.