Account for spacing when determining available space for star rows/columns

[hartez]

Fixes #3853
Fixes #3545

[rachelkang]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[rachelkang]

AFAICT this doesn't fix the issue :(

https://drive.google.com/file/d/1xb5FGcZ7CFrYgcocV5VQpfkUqfyAZ30n/view?usp=sharing

I don't think this has to do with the * as much as it has to do with Auto

[hartez]

AFAICT this doesn't fix the issue :(

https://drive.google.com/file/d/1xb5FGcZ7CFrYgcocV5VQpfkUqfyAZ30n/view?usp=sharing

I don't think this has to do with the * as much as it has to do with Auto

Can you post the test project you used for your video?

[rachelkang]

I put this sample code directly in my local version of the control gallery sample:

<views:BasePage
    xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
    xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
    x:Class="Maui.Controls.Sample.Pages.GridPage"
    xmlns:views="clr-namespace:Maui.Controls.Sample.Pages.Base"
    Title="Grid">
    <views:BasePage.Content>
        <GridLayout RowDefinitions="Auto,*, Auto">

            <Label Text="First label" />
            <StackLayout GridLayout.Row="0" x:Name="layoutSample" />
            <Button GridLayout.Row="1" Text="Add control" Clicked="Button_Clicked" Margin="0" Padding="20"/>

        </GridLayout>
    </views:BasePage.Content>
</views:BasePage>

using Microsoft.Maui.Controls;

namespace Maui.Controls.Sample.Pages
{
	public partial class GridPage
	{
		public GridPage()
		{
			InitializeComponent();
		}

	        private void Button_Clicked(object sender, System.EventArgs e)
	        {
		        layoutSample.Children.Add(new Label() { Text = "random label", HeightRequest = 100 });
	        }
	}
}

It uses <GridLayout RowDefinitions="Auto,*, Auto"> like the samples in the referenced issues do

[hartez]

@rachelkang I think your test XAML has some errors. Both the Label with the text "First Label" and the StackLayout are in row 0 of the Grid, and the Button is in row 1; the last row is empty.

Also, the issue doesn't appear unless the Grid has RowSpacing or ColumnSpacing greater than zero (depending on whether you're reproducing it vertically or horizontally).