Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix SetSemanticFocus #3993

Merged
merged 3 commits into from
Jan 20, 2022
Merged

[Android] Fix SetSemanticFocus #3993

merged 3 commits into from
Jan 20, 2022

Conversation

rachelkang
Copy link
Member

Description of Change

Fixes SetSemanticFocus for Android

Addresses half of #3472

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the WinUI, Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

Yes, for the better!

If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@PureWeen PureWeen enabled auto-merge (squash) January 20, 2022 20:31
@PureWeen PureWeen merged commit fd942bd into main Jan 20, 2022
@PureWeen PureWeen deleted the fix-set-semantic-focus branch January 20, 2022 21:09
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@Eilon Eilon added the t/a11y Relates to accessibility label May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
legacy-area-a11y Relates to accessibility platform/android 🤖 t/a11y Relates to accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants