Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Avoid crash using DisconnectHandler method with Layouts #4177

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Jan 18, 2022

Description of Change

Avoid crash using DisconnectHandler method with Layouts on Windows. The changes are mostly clear the layout childrens using the NativeView passed as parameter. Before the changes, invoking the Layout DisconnectHandler method

DisconnectHandler(oldNativeView);
was invoking the Clear method in the Latout thar try to access to the NativeView (LayoutPanel) that is already null and throw an exception.

Fix #3787

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

Does this PR touch anything that might affect accessibility?

  • No

@jsuarezruiz jsuarezruiz added t/bug Something isn't working platform/windows 🪟 labels Jan 18, 2022
@Redth Redth merged commit acb8f1c into main Jan 18, 2022
@Redth Redth deleted the fix-3787 branch January 18, 2022 17:39
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform/windows 🪟 t/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Windows] Application crash when call a DisconnectHandler while remove the view.
2 participants