Picker Handlers #433
Merged
Picker Handlers #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartez
approved these changes
Mar 5, 2021
|
@jsuarezruiz Needs a rebase. |
jsuarezruiz
force-pushed
the
pickerhandler
branch
from
0fbcf44
to
c6981cf
Compare
mattleibow
reviewed
Mar 13, 2021
Comment on lines
+9
to
+10
| IList<string> Items { get; } | ||
| IList ItemsSource { get; } |
There was a problem hiding this comment.
Do these two concepts mean anything at the core layer? This feels a bit binding-y. Also, how will Comet do this? Are we maybe forcing something?
Comment on lines
+9
to
+10
| { | ||
| UIPickerView? _pickerView; |
There was a problem hiding this comment.
Just found this on the Apple docs. Probably not essential for now, maybe...
Important
UIPickerView and its descendants aren’t available when the user interface idiom is UIUserInterfaceIdiomMac.
https://developer.apple.com/documentation/uikit/uipickerview
src/Core/tests/DeviceTests/Handlers/Picker/PickerHandlerTests.cs
Outdated
Show resolved
Hide resolved
| string GetNativeText(PickerHandler pickerHandler) => | ||
| GetNativePicker(pickerHandler).Text; | ||
|
|
||
| async Task ValidateNativeItemsSource(IPicker picker, int itemsCount) |
There was a problem hiding this comment.
I see this and the one below, are some tests missing that would have used it?
| if (pickerView?.Model is PickerSource source) | ||
| { | ||
| source.SelectedIndex = selectedIndex; | ||
| source.SelectedItem = selectedIndex >= 0 ? picker.Items[selectedIndex] : null; |
There was a problem hiding this comment.
Do we need to check for upper bounds here at all? selectedIndex >= 0 && selectedIndex < items.count
|
|
||
| namespace Microsoft.Maui | ||
| { | ||
| public class NativePicker : NativePickerBase |
There was a problem hiding this comment.
Can we merge these two types at all? Maybe even PickerManager?
|
|
||
| namespace Microsoft.Maui | ||
| { | ||
| internal static class PickerManager |
There was a problem hiding this comment.
Will something like this be used by TimePicker? Not sure how much overhead there is on this?
hartez
added a commit
that referenced
this pull request
Mar 17, 2021
* PickerHandlers * Nullability fixes * Updated Picker device tests * New things in the tests! * Removed unnecessary Android Api level validation * Added Picker Items null validation in iOS PickerHandler * Moved Picker Handler tests between different classes * Renamed NativePicker to MauiPicker * Removed unused code from iOS PickerExtensions * Fix build error * Fix build error * Remove duplicate class Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: E.Z. Hart <hartez@gmail.com>
Merged
hartez
added a commit
that referenced
this pull request
Mar 18, 2021
* PickerHandlers * Nullability fixes * Updated Picker device tests * New things in the tests! * Removed unnecessary Android Api level validation * Added Picker Items null validation in iOS PickerHandler * Moved Picker Handler tests between different classes * Renamed NativePicker to MauiPicker * Removed unused code from iOS PickerExtensions * Fix build error * Fix build error * Remove duplicate class Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: E.Z. Hart <hartez@gmail.com>
hartez
added a commit
that referenced
this pull request
Mar 18, 2021
* TimePicker Handlers (#454) * TimePickerHandlers * Undo changes in sample * Add some nullability fixes * Fix build error * Changes from PR feedback * Fixed build error * Updated tests * Roll time picker and popup into one control * Move 24 hour view check to handler * Pull NSLocale -> CultureInfo code out to common property Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: E.Z. Hart <hartez@gmail.com> * CheckBoxHandlers (#432) * Rename ICheck -> ICheckBox, remove Color stuff (to be replaced with Brush later), fix DeviceTests * Implement CharacterSpacing property in EditorHandlers (#516) * Fix broken test and incorrect CharacterSpacing on iOS * Implement HorizontalTextAlignment property in EntryHandlers (#524) * Better text on example * Remove IView from ITextAlignment * Remove IView from IPlaceholder * Implement IsTextPredictionEnabled property on Editor (#515) * Initial implementation * Added Tests * Added PortHandler Attributes * Added Tests * Handle turning text prediction back on Co-authored-by: E.Z. Hart <hartez@gmail.com> * Implement ReturnType property in EntryHandlers (#518) * Implement CharacterSpacing property in SearchBarHandlers (#494) * Implement CharacterSpacing in SearchBarHandlers * Tests failing because of static * Rounding for Android * Fix iOS test * There! No magic numbers! * Fix rebase issuse and make SearchBar stuff work on iOS Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: E.Z. Hart <hartez@gmail.com> * Stepper Handlers (#517) * StepperHandlers * Fixed Stepper handler broken tests * Remove duplicate searchbar * Add IStepper interface Co-authored-by: E.Z. Hart <hartez@gmail.com> * IStepper.Increment -> IStepper.Step * Picker Handlers (#433) * PickerHandlers * Nullability fixes * Updated Picker device tests * New things in the tests! * Removed unnecessary Android Api level validation * Added Picker Items null validation in iOS PickerHandler * Moved Picker Handler tests between different classes * Renamed NativePicker to MauiPicker * Removed unused code from iOS PickerExtensions * Fix build error * Fix build error * Remove duplicate class Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: E.Z. Hart <hartez@gmail.com> * ActivityIndicator Handlers (#417) * ActivityIndicatorHandler * Register IActivityIndicator * Add comments to IActivityIndicator * Fix build error * Implement Font properties in SearchBarHandlers (#533) * Speed up PR builds (#510) Reduce the jobs and use the new pools * implement Font properties in SearchBarHandlers * Fix rebase issues Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: E.Z. Hart <hartez@gmail.com> * Implemented LineHeight on Label (#538) * Implemented LineHeight on Label (#368) * Fix-up after rebase Co-authored-by: E.Z. Hart <hartez@gmail.com> * Fix broken label tests; add some missing label tests; attributed string cleanup * Consolidate and rename extension method classes * Fix class names and de-duplicate methods * Centralize time extensions * Fix mapping Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: Glenn Hevey <glenn.hevey@gmail.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: Amr <hassaninamr@yahoo.com>
samhouts
added
legacy-area-controls
Eilon
removed
the
legacy-area-controls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Picker Handlers. This PR will allow adding a basic Picker support, in the firsts .NET MAUI Preview.
Related issues:
Platforms Affected