Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinUI TabbedPage Tests/Cleanup/BarBackground #4360

Merged
merged 8 commits into from
Jan 28, 2022
Merged

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Jan 27, 2022

Description of Change

  • Add more UI Tests for TabbedPageHandler
  • Fixed an issue when disconnecting and swapping in a new TabbedPageHandler
    • You can test this by going to the TabbedPage gallery and clicking the button to swap in TabbedPage as root
  • Wired up BarBackground(Color)
  • Fixed a few issues with FlyoutPage when used with TabbedPage

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the WinUI, Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

  • Does this PR introduce a new control? (If yes, add an example using SemanticProperties to the SemanticsPage)
  • APIs that modify focusability?
  • APIs that modify any text property on a control?
  • Does this PR modify view nesting or view arrangement in anyway?
  • Is there the smallest possibility that your PR will change accessibility?
  • I'm not sure, please help me

If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.

# Conflicts:
#	src/Controls/src/Core/Handlers/TabbedPage/TabbedPageHandler.Windows.cs
#	src/Core/src/Platform/Windows/FrameworkElementExtensions.cs
#	src/Core/src/Platform/Windows/NavigationRootManager.cs
#	src/Core/src/Platform/Windows/NavigationViewExtensions.cs
@PureWeen PureWeen enabled auto-merge (squash) January 27, 2022 23:37
@PureWeen PureWeen merged commit 9e46f20 into main Jan 28, 2022
@PureWeen PureWeen deleted the winui_tabbedpage_apis branch January 28, 2022 02:55
@PureWeen PureWeen linked an issue Jan 31, 2022 that may be closed by this pull request
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NavigationPage.HasBackButton property not working in Windows 11
2 participants