Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WinUI] Fix Alignment and Header Visibility #4400

Merged
merged 3 commits into from
Jan 30, 2022
Merged

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Jan 29, 2022

Description of Change

  • Fixes an issue with the Header not being visible on non tabbedpages
  • Removes a margin on the Header when used with TabbedPage
  • Fix the Title Alignment when the Header is part of a NavPage vs TabbedPage
  • Added Additional Tests

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the WinUI, Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

  • Does this PR introduce a new control? (If yes, add an example using SemanticProperties to the SemanticsPage)
  • APIs that modify focusability?
  • APIs that modify any text property on a control?
  • Does this PR modify view nesting or view arrangement in anyway?
  • Is there the smallest possibility that your PR will change accessibility?
  • I'm not sure, please help me

If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.

@PureWeen PureWeen added this to the 6.0.200-preview.13 milestone Jan 29, 2022
@PureWeen PureWeen changed the title Fix Alignment and Header Visibility [WinUI] Fix Alignment and Header Visibility Jan 29, 2022
@PureWeen PureWeen enabled auto-merge (squash) January 29, 2022 16:17
@PureWeen PureWeen requested a review from Redth January 29, 2022 17:59
@Redth Redth modified the milestone: 6.0.200-preview.13 Jan 30, 2022
@PureWeen PureWeen merged commit f47616c into main Jan 30, 2022
@PureWeen PureWeen deleted the winui_tabbedpage_fixes branch January 30, 2022 21:53
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@Eilon Eilon removed legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor area-controls-pages Page types labels May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants