Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure all @(Compile) items appear in the Solution Explorer #4411

Merged
merged 4 commits into from
Feb 1, 2022
Merged

Make sure all @(Compile) items appear in the Solution Explorer #4411

merged 4 commits into from
Feb 1, 2022

Conversation

mattleibow
Copy link
Member

@mattleibow mattleibow commented Jan 30, 2022 •
edited

Description of Change

This PR moves the logic to remove the Compile items from the various Platform/* folders. This is done in a separate target so that the IDE can evaluate the project and show all the files, but before any compilation/designer work is done, we make sire to adjust the list of Compile items to make sure we don't build Android on iOS or similar.

Partially fixes #4410

Additions made

  • Adds

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the WinUI, Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

  • Does this PR introduce a new control? (If yes, add an example using SemanticProperties to the SemanticsPage)
  • APIs that modify focusability?
  • APIs that modify any text property on a control?
  • Does this PR modify view nesting or view arrangement in anyway?
  • Is there the smallest possibility that your PR will change accessibility?
  • I'm not sure, please help me

If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.

@mattleibow
Add the ignored .cs files to None
f2a265e 
Without files being added to None, the IDE will not display them
@mattleibow mattleibow marked this pull request as draft January 30, 2022 20:50
@mattleibow mattleibow requested a review from Redth January 30, 2022 20:50
@mattleibow mattleibow added this to the 6.0.200-preview.13 milestone Jan 30, 2022
@mattleibow mattleibow changed the base branch from main to release/6.0.2xx-preview13 January 31, 2022 20:48
@mattleibow mattleibow marked this pull request as ready for review January 31, 2022 21:08
@mattleibow mattleibow changed the title Add the ignored .cs files to None Make sure all @(Compile) items appear in the Solution Explorer Jan 31, 2022
jonathanpeppers
jonathanpeppers approved these changes Jan 31, 2022
View reviewed changes
.nuspec/Microsoft.Maui.Controls.SingleProject.targets
correct time for the build to be adjusted.
-->
<Target Name="_MauiRemovePlatformCompileItems"
BeforeTargets="_MauiInjectXamlCssAdditionalFiles;GenerateMSBuildEditorConfigFileShouldRun"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point we might change GenerateMSBuildEditorConfigFileShouldRun -> CoreCompile everywhere, but let's do that later if this is working. Should we file an issue on that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! #4431

@Redth Redth merged commit 49e446f into release/6.0.2xx-preview13 Feb 1, 2022
@Redth Redth deleted the dev/none branch February 1, 2022 01:35
@jonathanpeppers jonathanpeppers mentioned this pull request Feb 1, 2022
Closed
Redth added a commit that referenced this pull request Feb 1, 2022
@Redth @mattleibow @rmarinho
Backport preview 13 fixes (#4434)
2831b6a 
* Update MAUI Graphics

* Update Forms.cs

* Update DeviceInfo.ios.tvos.watchos.cs

* Make sure all @(Compile) items appear in the Solution Explorer (#4411)

* Add the ignored .cs files to None

Without files being added to None, the IDE will not display them

* Move the adjustments into a target

* Fix coherent dependency (#4436)

* Fix CoherentParentDependency

* Revert back to Microsoft.AspNetCore.App.Runtime.win-x64

* Revert FileProviders.Embedded

Co-authored-by: Matthew Leibowitz <mattleibow@live.com>
Co-authored-by: Rui Marinho <me@ruimarinho.net>
@mattleibow mattleibow mentioned this pull request Feb 4, 2022
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Redth Redth Redth approved these changes

@jonathanpeppers jonathanpeppers jonathanpeppers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
[ARCHIVED] MAUI Planning
Status: Done
Milestone
6.0.200-preview.13
3 participants
@mattleibow @Redth @jonathanpeppers