Ensure that using the AndExpand Grid hack doesn't null out BindingContext #4455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
reviewed
Feb 1, 2022
mattleibow
approved these changes
Feb 2, 2022
jsuarezruiz
approved these changes
Feb 2, 2022
Redth
approved these changes
Feb 2, 2022
hartez
force-pushed
the
preserve-bindingcontext-andexpand
branch
from
52d5e3f
to
57d5cae
Compare
Redth
reviewed
Feb 2, 2022
Co-authored-by: Jonathan Dick <jodick@microsoft.com>
Redth
approved these changes
Feb 2, 2022
mattleibow
approved these changes
Feb 2, 2022
mattleibow
added
the
area-layout
This was referenced Feb 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AndExpandLayoutManager is de-parenting child controls each time it measures/lays out the children after the first pass.
These changes modify the
AndExpandGridto avoid de-parenting the controls during theClear()operation.Fixes #3970