Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add microsoft.net.workload.mono.toolchain back into the rollback.json #4481

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

mattleibow
Copy link
Member

Description of Change

When installing from a rollback file, we also want to make sure we install the toolchain: microsoft.net.workload.mono.toolchain

@mattleibow mattleibow self-assigned this Feb 2, 2022
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a PR here: jonathanpeppers/maui-profiling#6

What was happening before:

Writing workload pack installation record for Microsoft.NETCore.App.Runtime.AOT.Cross.iossimulator-x64 version 6.0.1...

After adding microsoft.net.workload.mono.toolchain, it does the right thing:

Installing pack Microsoft.NETCore.App.Runtime.AOT.Cross.iossimulator-x64 version 6.0.2-mauipre.1.22074.5...

@mattleibow mattleibow merged commit e839da5 into main Feb 2, 2022
@mattleibow mattleibow deleted the dev/rollback-toolchain branch February 2, 2022 22:23
@mattleibow mattleibow added the area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions label Feb 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants