Remove unsupported targets in Device class #4491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
commented
Feb 3, 2022
|
The whole UWP to WinUI makes me think about the compatibility story. Everyone will need to update all their XAML for this. |
27 tasks
|
Whatever we do here, we need to match in the essentials DeviceInfo API because this is going to use that eventually with #1965 |
|
Pending questions:
|
|
|
We can maybe remove UWP in net7 |
@Redth Maintain UWP until .NET 7? |
|
mark UWP as Obsolete |
Redth
reviewed
Mar 3, 2022
Redth
reviewed
Mar 3, 2022
src/Controls/tests/Xaml.UnitTests/MarkupExpressionParserTests.cs
Outdated
Show resolved
Hide resolved
Redth
approved these changes
Mar 3, 2022
jsuarezruiz
commented
Mar 3, 2022
| @@ -94,6 +94,51 @@ public void TypeConverterAndDerivedTypes() | |||
| image = new Image().LoadFromXaml(xaml); | |||
| Assert.AreEqual("icon_twitter.png", (image.Source as FileImageSource).File); | |||
| } | |||
|
|
|||
| [Test] | |||
| public void UWPisWinUI() | |||
18 tasks
Redth
added a commit
that referenced
this pull request
Mar 4, 2022
* Implement IBorder on Windows (#5008) * Implement IBorder on Windows * Fix rectangles Co-authored-by: redth <jondick@gmail.com> * Remove all usage of Device throughout the repo (#4982) * Remove unsupported targets in Device class (#4491) * Remove unsupported targets in Device class * Fixed broken tests * Deprecate UWP target * Allow to use UWP target on XAML * Fix build errors * comments * UWP == WinUI * Fix Build errors * Added more tests * fix * vbnm * More fixes * things Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com>
Redth
added a commit
that referenced
this pull request
Mar 4, 2022
* Implement IBorder on Windows (#5008) * Implement IBorder on Windows * Fix rectangles Co-authored-by: redth <jondick@gmail.com> * Remove all usage of Device throughout the repo (#4982) * Remove unsupported targets in Device class (#4491) * Remove unsupported targets in Device class * Fixed broken tests * Deprecate UWP target * Allow to use UWP target on XAML * Fix build errors * comments * UWP == WinUI * Fix Build errors * Added more tests * fix * vbnm * More fixes * things Co-authored-by: Matthew Leibowitz <mattleibow@live.com> * [ci] Remove image override (#5053) * [ci] Remove image override * [ci] Don't provisioning windows Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: Rui Marinho <me@ruimarinho.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Targets not supported by .NET MAUI like GTK, WPF, UWP have been marked as internal. WinUI has also been added as a target.
PR Checklist
Does this PR touch anything that might affect accessibility?