Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SecureStorage into an interface #4668

Merged
merged 10 commits into from Feb 24, 2022

Conversation

antonfirsov
Copy link
Member

@antonfirsov antonfirsov commented Feb 14, 2022

Description of the change

Contributes to #4497.

Additions made

public interface ISecureStorage
{
	Task<string> GetAsync(string key);
	Task SetAsync(string key, string value);
	bool Remove(string key);
	void RemoveAll();
}

public class SecureStorageImpl : ISecureStorage{ /*... */ }

@rmarinho
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jsuarezruiz jsuarezruiz added the area-essentials Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info label Feb 14, 2022
@rmarinho
Copy link
Member

         D:\a\_work\1\s\src\Essentials\test\DeviceTests\Tests\SecureStorage_Tests.cs(32,33): error CS1501: No overload for method 'SetAsync' takes 3 arguments [D:\a\_work\1\s\src\Essentials\test\DeviceTests\Essentials.DeviceTests.csproj]

Build failing

@antonfirsov
Copy link
Member Author

@rmarinho do we need clean CI on this and other Essentials PR-s? The failures I see so far seem to be unrelated.

@rmarinho
Copy link
Member

image

seems some tests are failing , do they work locally ?

@antonfirsov
Copy link
Member Author

@rmarinho thanks, addressed! How to navigate to the view you pasted? I usually go here:

image

but none of the checks I've seen listed test failures.

@rmarinho
Copy link
Member

You can go to the Tests tab

image

@rmarinho rmarinho requested a review from Redth February 21, 2022 14:49
antonfirsov and others added 5 commits February 22, 2022 13:45
In a few other PR's for Essentials refactoring we started adding the `IPlatformX` interface as a place to host platform specific things.

This adjusts to the same pattern used there.
@Redth Redth merged commit 74f7584 into dotnet:main Feb 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-essentials Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants