New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor SecureStorage into an interface #4668
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
jsuarezruiz
added
the
area-essentials
Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info
label
Feb 14, 2022
Build failing |
37 tasks
antonfirsov
commented
Feb 15, 2022
src/Essentials/src/SecureStorage/SecureStorage.ios.tvos.watchos.macos.cs
Outdated
Show resolved
Hide resolved
@rmarinho do we need clean CI on this and other Essentials PR-s? The failures I see so far seem to be unrelated. |
@rmarinho thanks, addressed! How to navigate to the view you pasted? I usually go here: but none of the checks I've seen listed test failures. |
rmarinho
approved these changes
Feb 21, 2022
mattleibow
reviewed
Feb 21, 2022
mattleibow
previously requested changes
Feb 21, 2022
src/Essentials/src/SecureStorage/SecureStorage.ios.tvos.watchos.macos.cs
Outdated
Show resolved
Hide resolved
src/Essentials/src/SecureStorage/SecureStorage.ios.tvos.watchos.macos.cs
Outdated
Show resolved
Hide resolved
In a few other PR's for Essentials refactoring we started adding the `IPlatformX` interface as a place to host platform specific things. This adjusts to the same pattern used there.
Redth
approved these changes
Feb 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Contributes to #4497.
Additions made