Add single target build ProjectCapability #4791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
added
the
area-single-project
drasticactions
approved these changes
Feb 19, 2022
| @@ -104,6 +104,7 @@ | |||
| <ProjectCapability Include="XamarinStaticLaunchProfiles" Condition=" '$(VisualStudioVersion)' != '' and '$(VisualStudioVersion)' < '17.0' " /> | |||
| <!-- Otherwise define LaunchProfilesGroupByPlatformFilters by default --> | |||
| <ProjectCapability Include="LaunchProfilesGroupByPlatformFilters" Condition=" '$(VisualStudioVersion)' == '' or '$(VisualStudioVersion)' >= '17.0' " /> | |||
| <ProjectCapability Include="SingleTargetBuildForStartupProjects" /> | |||
There was a problem hiding this comment.
Two questions:
- Did we test this works in the IDE? I worry that the capability won't be there, the way workloads work. It seems like the "outer" build doesn't load any workload MSBuild targets.
- Should we also put this in each platform workload? Like you could do a
<TargetFrameworks>net6.0-android;net6.0-ios;net6.0-windows</TargetFrameworks>and not be using MAUI? Like a multi-targeted SkiaSharp app or something.
There was a problem hiding this comment.
To test this try:
<ItemGroup>
<ProjectCapability Include="DiagnoseCapabilities" />And it should list them all in the solution tree.
|
@tmeschter is this something we should be doing still? |
|
Yes, we still need this capability for the feature to light up. |
|
Seems to work I think:
|
|
@mattleibow can we add a condition to this to disable the include in case someone needs to back out of it? |
|
I believe this setting needs to be on to do the right thing too? |
Redth
approved these changes
Apr 19, 2022
|
Actually it's this setting:
Possibly we should consolidate both settings onto the "Build And Run" page. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add the capability to make use of new IDE features.