Wire up build targets to exclude content items from iOS and Android checks #4861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiercn
reviewed
Feb 24, 2022
|
|
||
| <!-- Update Content files that are managed by the Razor SDK to opt out of iOS and Android content-checks --> | ||
| <ItemGroup> | ||
| <_ContentNotStaticWebAsset Include="@(Content)" Exclude="@(StaticWebAsset)" /> |
There was a problem hiding this comment.
I believe this needs to be as below:
Suggested change
| <_ContentNotStaticWebAsset Include="@(Content)" Exclude="@(StaticWebAsset)" /> | |
| <_ContentNotStaticWebAsset Include="@(Content)" Exclude="%(StaticWebAsset.OriginalItemSpec)" /> |
The reason is that StaticWebAssets always use the full path to the item, and capture the original definition within OriginalItemSpec
There was a problem hiding this comment.
Turns out we don't need to do this - RazorSDK removes SWA items from Content which makes this a lot easier since we don't have to do set intersections (the list of items that are neither SWA nor ScopedCssInputs).
There was a problem hiding this comment.
I think we still need to do this for ScopedCssInputs as they get removed from SWA as part of bundling (but I might be wrong)
javiercn
reviewed
Feb 24, 2022
src/BlazorWebView/src/Maui/build/Microsoft.AspNetCore.Components.WebView.Maui.targets
Outdated
Show resolved
Hide resolved
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #791