Remove IPlatformServices.RequestedTheme
and use Essentials
#4964
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The logic for the app theme is split up a bit, Essentials just reports the current theme and Core handled the change events on the views.
This PR merges all the ideas and removes the redundancy.
Device.RequestedTheme
just uses the Essentials API, and when Core decides it is time to trigger a theme change event, it fires the event and then Controls puts it all together.Part of #1965
Additions made
IPlatformServices
(finally)OSAppTheme
in favour of the exactly the sameAppTheme
from essentialsPR Checklist
Does this PR touch anything that might affect accessibility?
If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.