-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some crashing tests #5261
Fix some crashing tests #5261
Conversation
lol:
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattleibow seems some tests failing on API23 .. CanLoadFonts |
For some reason, the same font is loaded but with different handles on older devices. It is not default font, so it seems that it just loaded 2 of the same fonts n memory... |
# Conflicts: # src/Core/src/Platform/Android/PlatformVersion.cs
Description of Change
One test seemed to go bad after #4933 and that was because the PR did not catch the bad test. This is because of 2 reasons:
We have disabled the warnings because we have an API that we use that the analyzer did not know about. We are in the process of fixing this, but we went too far and turned off the warnings instead of downgrading to suggestions.
We don't because there are a lot to test, but maybe we should have the latest and the oldest in the PR just to be safe. The runs are pretty quick on the accelerated bots, so this won't add much time.
Issues Fixed
A crashing test and total lack of warnings.
NOTE
I was unable to fix the tests on older Android devices, so I disabled them there and opened this issue: #5903