Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix Opacity property in Image #5607

Merged
merged 1 commit into from
Mar 28, 2022
Merged

[Android] Fix Opacity property in Image #5607

merged 1 commit into from
Mar 28, 2022

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Fix Opacity property in Android Image.

Before
issue-image-opacity-before

After
issue-image-opacity-after

Issues Fixed

Fixes #5568

@jsuarezruiz jsuarezruiz added t/bug Something isn't working platform/android 🤖 area-image Image loading, sources, caching labels Mar 28, 2022
@@ -24,6 +24,7 @@ public static void MapBackground(IImageHandler handler, IImage image)
handler.UpdateValue(nameof(IViewHandler.ContainerView));

handler.ToPlatform().UpdateBackground(image);
handler.ToPlatform().UpdateOpacity(image);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Android the Image the ContainerView setting the Background property because is the way to support correctly gradients. In case we set the ContainerView, update the opacity to apply it also to the container.

@Redth Redth merged commit 8fb8d2d into main Mar 28, 2022
@Redth Redth deleted the fix-5568 branch March 28, 2022 14:29
@Redth Redth added this to the 6.0.300-rc.1 milestone Mar 28, 2022
@AyKarambo
Copy link

There is the same issue for frames.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@Eilon Eilon added area-controls-image Image control and removed area-image Image loading, sources, caching labels May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-image Image control platform/android 🤖 t/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opacity is ignored for Image background
4 participants