Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump templates to be visible in VS 17.3 and up #5626

Merged
merged 1 commit into from
May 11, 2022
Merged

Conversation

jfversluis
Copy link
Member

Description of Change

What the title says. Do not merge until 17.2 goes GA

@jfversluis jfversluis added t/housekeeping ♻︎ do-not-merge Don't merge this PR area-templates Project templates, Item Templates for Blazor and MAUI labels Mar 29, 2022
@jfversluis jfversluis requested a review from a team as a code owner March 29, 2022 07:52
Copy link
Member

@Eilon Eilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit. Added @phenning for an extra set of eyes of template expertise.

@phenning
Copy link
Contributor

Ack, if the desire is for the templates to not be visible on 17.2 and earlier.

@jfversluis jfversluis marked this pull request as draft March 29, 2022 19:15
@jfversluis
Copy link
Member Author

Just to be sure: we want to show it on 17.3 and up but not yet right now. Converting to draft just to be sure we don't push wrong buttons too early. But thanks for the quick reviews! :D

@jfversluis jfversluis added this to the 6.0.300 milestone May 10, 2022
@jfversluis jfversluis marked this pull request as ready for review May 10, 2022 09:17
@jfversluis jfversluis removed the do-not-merge Don't merge this PR label May 10, 2022
@rmarinho rmarinho merged commit dbbe782 into main May 11, 2022
@rmarinho rmarinho deleted the template-173-bump branch May 11, 2022 09:38
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-templates Project templates, Item Templates for Blazor and MAUI t/housekeeping ♻︎
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants