Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CharacterSpacing property in EntryHandlers #566

Merged
merged 2 commits into from
Mar 23, 2021
Merged

Implement CharacterSpacing property in EntryHandlers #566

merged 2 commits into from
Mar 23, 2021

Conversation

almirvuk
Copy link
Contributor

Description of Change

Implement CharacterSpacing property in EntryHandlers.

Related issue #382

Platforms Affected

  • Core
  • iOS
  • Android

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

@almirvuk almirvuk changed the title Implement CharacterSpacing property in EntryHandles #382 Implement CharacterSpacing property in EntryHandles Mar 21, 2021
@@ -375,6 +375,7 @@ void UpdateText()
Control.Text = text;
}

[PortHandler]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would still need to port code related to the Placeholder, could you add a comment here?

[PortHandler ("Partially ported ...")]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe that needs to be done in this PR? The Placeholder property is already in the new handlers, so I think for this feature to be implemented completely, it needs to update the placeholder as well. Unless there is some specific reason why it can't be done now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side it makes sense also, I can do it in this PR :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattleibow since this was merged by hartez I will finish the Placeholder part in another PR :)

@hartez hartez changed the title Implement CharacterSpacing property in EntryHandles Implement CharacterSpacing property in EntryHandlers Mar 22, 2021
@hartez
Copy link
Contributor

hartez commented Mar 23, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hartez hartez merged commit 1768c24 into dotnet:main Mar 23, 2021
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants