Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blazor] Support unpackaged Win UI apps #5880

Merged
merged 5 commits into from
Apr 8, 2022

Conversation

javiercn
Copy link
Member

@javiercn javiercn commented Apr 7, 2022

Description of Change

Adds support for unpackaged apps by detecting when the app is not packaged and using the file system APIs instead. The files are located in the application root subfolder.

image

Issues Fixed

Fixes #3166

@javiercn javiercn requested a review from a team as a code owner April 7, 2022 16:24
Co-authored-by: Eilon Lipton <Eilon@users.noreply.github.com>
@TanayParikh TanayParikh added the area-blazor Blazor Hybrid / Desktop, BlazorWebView label Apr 7, 2022
The second is more "correct"

Co-authored-by: Eilon Lipton <Eilon@users.noreply.github.com>
@javiercn
Copy link
Member Author

javiercn commented Apr 8, 2022

@Eilon I've updated Environment.CurrentDirectory to use AppContext.BaseDirectory, it's what it is suggested here and what we do in other places on ASP.NET Core.

@Eilon Eilon merged commit 91eba52 into main Apr 8, 2022
@Eilon Eilon deleted the javiercn/winui-support-unpackaged-apps branch April 8, 2022 16:33
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Blazor Hybrid / Desktop, BlazorWebView
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Support for WinUI Unpackaged Apps
4 participants