Prevent ScrollView on Android and Windows from entering a bad layout state #5897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…state when no padding/margin are specified Fixes #5717
jsuarezruiz
approved these changes
Apr 8, 2022
jsuarezruiz
added
t/bug
mattleibow
reviewed
Apr 8, 2022
| @@ -24,6 +24,7 @@ protected override void ConnectHandler(MauiScrollView platformView) | |||
| { | |||
| base.ConnectHandler(platformView); | |||
| platformView.ScrollChange += ScrollChange; | |||
| platformView.CrossPlatformArrange = VirtualView.CrossPlatformArrange; | |||
There was a problem hiding this comment.
Are we missing a null set on the detach? How do we prevent memory leaks with this?
Or can't this happen in this case?
There was a problem hiding this comment.
Just missed it. Fixed.
|
@hartez @jsuarezruiz What can we expect a new RC with the fix? We cannot start development until it works fine |
Eilon
added
area-controls-scrollview
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When no padding/margin are specified, the Windows and Android ScrollViews can reach a layout state where requests for subsequent layout updates are ignored. These changes prevent that from happening.
Issues Fixed
Fixes #5717