[Android] Fix issues rendering gradients and CornerRadius on Button #5971
Conversation
jsuarezruiz
added
t/bug
| if (background is SolidPaint) | ||
| platformView.UpdateBackground(background); | ||
| else | ||
| platformView.UpdateBorderDrawable(button); |
There was a problem hiding this comment.
Why do we have this issue? Basically because we have implemented Handlers, in this specific case the Button in different phases and we have not detected this problem with tests. We initially implement the Background property using an AppCompatButton. Subsequently, by implementing properties related to the Border (BorderWidth, etc) we change the type of native control to use for a MaterialButton.
The MaterialButton requires BackgroundTintList to be set to null in order to render a custom background. If a custom background is set, a Drawable is used where the background is drawn and, if there is a border, use the Drawabable too. Otherwise, the BackgroundColor property and the StrokeWidth etc properties of the MaterialButton itself are used.
Eilon
added
the
legacy-area-controls
Eilon
removed
the
legacy-area-controls
Description of Change
Fix issues rendering gradients and corner radius on Android Button.
Issues Fixed
Fixes #5950
Fixes #5930