Views spanning both auto and star cells should not contribute to the Auto size #6106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te to the Auto size Fixes #5657
rmarinho
added
the
area-layout
PureWeen
approved these changes
Apr 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Views which span multiple rows/columns and have at least one star row/column in the span should not be determining the width/height of the auto rows/columns in the span. The MAUI Grid is not currently working that way, which effectively makes the Auto rows/columns use the remaining available space when determining their size.
These changes make the MAUI Grid handle this situation the same way Forms/UWP/WinUI/WPF do.
Issues Fixed
Fixes #5657