Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create custom Automation Peer for MauiButton #6139

Merged
merged 1 commit into from
Apr 18, 2022
Merged

Conversation

PureWeen
Copy link
Member

Description of Change

  • Create a MauiButton since we already have a bunch of custom logic inside CreatePlatformView that a user would need to replicate our button. This also lets us create a custom AutomationPeer which you can only do through inheritance
  • This lets us remove all the children from the accessibility tree and use the TextBlock as the labelfor the button. Prior to this behavior Narrator would select the button and provide no useful description and would then navigate to the TextBlock inside the Button.

@Eilon Eilon added area-controls-button Button, ImageButton legacy-area-a11y Relates to accessibility legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor labels Apr 15, 2022
Copy link
Member

@rachelkang rachelkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!! Thanks for figuring this out

@Redth Redth merged commit fe64012 into main Apr 18, 2022
@Redth Redth deleted the fix_winui_button_automation branch April 18, 2022 18:53
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@Eilon Eilon added t/a11y Relates to accessibility and removed legacy-area-a11y Relates to accessibility legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor labels May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-button Button, ImageButton t/a11y Relates to accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants