Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The benchmark method name
GoTo
passes the idea that we want to measure the Shell Navigation, but we're measuring more than that.At this PR I moved the Shell initialization to a global method, to make sure that the benchmark will measure just the
GoToAsync
method. Before this change, the benchmark was measuring the shell initialization + navigation.Main
branchThis branch
As you can see the values changed a lot, indicating that we are measuring more than the navigation.
Issues Fixed
There's no issue for this, I can create one if needed.