Add Try/Catch wrapper around iOS StatusBar rendering #6201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
approved these changes
Apr 18, 2022
|
Could you create a new issue and add it to the 6.0.300 milestone. |
Assigned to me for now, I think I have an idea of how to fix this properly, but this will at least stop it throwing and give us more time to get it implemented (with proper tests!) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
"Fixes" #5693
This adds a try/catch wrapper around getting the status bar for the Window on iOS. The original obj/c error will still throw, but it will still let us render the screen with the status bar hidden.
We need a longer term task to add better error handling in here (since I don't believe there is a logger available here in Essentials).