Use infinity for measure constraints when determining auto sizes #6217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
the
area-layout
rmarinho
approved these changes
Apr 19, 2022
|
Hi ! i was about to file an issue about an unexpected behavior in a grid nested inside a stacklayout, but this looks probably related so i will try to reproduce it with the latest from the main branch and let you know if that fixes it. maui: compared to same layout on Xamarin.Forms (this is the expected layout according to my knowledge of the layout APIs): |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The Grid is not properly measuring Auto rows/columns to their full possible values; they were being artificially constrained to the remaining space in the Grid. They should be measured at infinity in their Auto direction.
These changes make that happen, and add tests to ensure it.
Issues Fixed
Fixes #2107