Allow closing of windows when using a MainPage #6316
Conversation
mattleibow
added
the
legacy-area-desktop
|
|
||
| if (_singleWindowMainPage != null) | ||
| window.Page = null; |
There was a problem hiding this comment.
This was added in #4860 but will never be reached.
| </PropertyGroup> | ||
| <Import Project="$(MauiNuSpecDirectory)Microsoft.Maui.Controls.MultiTargeting.targets" /> | ||
| <ItemGroup Condition=" '$(TargetPlatformIdentifier)' == 'android' "> | ||
| <!-- remove other AndroidX packages from the MultiTargeting --> | ||
| <PackageReference Remove="*" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.DotNet.GenAPI" Version="6.0.0-*" PrivateAssets="all" /> |
There was a problem hiding this comment.
This should never have reached main. It was me testing things. :(
@mattleibow here's a gist of the errors: https://gist.github.com/rachelkang/2751bf23ff2b579f8b63c1886be1ec51 I'm only seeing this on this branch and not on main / other branches |
|
These errors are not connected since the nugets are basically just a build task to write some text files. Did you git clean? |
|
@mattleibow yeah I did git clean -xfd :/ This is what shows up in the error list: |
Ah yeah, this is a known issue in our repo. Just run again and the next time should work. I think we have some build tasks that are running in the background so they conflict. |
Eilon
added
the
t/desktop
Description of Change
The initial work in #4860, there was work to avoid clearing up the window that is still being used.
This PR reduces the prevention to only prevent the closure of the MainPage window.
Issues Fixed
Fixes #6103
Related to: #4860