Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix android image loading into views #6394

Merged
merged 3 commits into from
Apr 22, 2022
Merged

Conversation

Redth
Copy link
Member

@Redth Redth commented Apr 22, 2022

  • Clean up code using lambdas in java
  • Use the MauiCustomViewTarget's view directly

I think the main fix here is using the builder with caching was not retaining the correct builder instance in those cases, this fixes the logic.

fixes #6231
fixes #6228
fixes #6363
fixes #6067

Screenshot_1650588688

- Clean up code using lambdas in java
- Use the MauiCustomViewTarget's view directly

I think the main fix here is using the builder with caching was not retaining the correct builder instance in those cases, this fixes the logic.
@Redth Redth requested a review from PureWeen April 22, 2022 00:50
@Redth Redth added this to the 6.0.300-rc.3 milestone Apr 22, 2022
@Redth Redth requested a review from jsuarezruiz April 22, 2022 00:52
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a real test failure?

InvalidSourceFailsToLoad
Assert.Equal() Failure\nExpected: List<String> ["LoadingStarted", "LoadingFailed"]\nActual:   List<String> ["LoadingStarted"]

I clicked retry, just in case.

@Redth
Copy link
Member Author

Redth commented Apr 22, 2022

I think it is a real failure, but I haven't quite figured out why yet.

@jonathanpeppers
Copy link
Member

Maybe it only passed because things weren’t fully working before.

@Redth
Copy link
Member Author

Redth commented Apr 22, 2022

Not sure, I can't seem to make it fail locally... Could be an API level thing I guess, or perhaps the tests are taking too long in CI?

Screen Shot 2022-04-21 at 11 09 12 PM

@Redth
Copy link
Member Author

Redth commented Apr 22, 2022

Though I suppose that test is now timing out so that's probably not correct.

@Redth
Copy link
Member Author

Redth commented Apr 22, 2022

Ok I'm not sure what's happening inside Glide, but the load does actually take this long to fail. I was setting breakpoints in the java code, and from calling .into(target) to onLoadFailed in the target, is like 5 seconds with an invalid filename...

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants