-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix android image loading into views #6394
Conversation
- Clean up code using lambdas in java - Use the MauiCustomViewTarget's view directly I think the main fix here is using the builder with caching was not retaining the correct builder instance in those cases, this fixes the logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a real test failure?
InvalidSourceFailsToLoad
Assert.Equal() Failure\nExpected: List<String> ["LoadingStarted", "LoadingFailed"]\nActual: List<String> ["LoadingStarted"]
I clicked retry, just in case.
I think it is a real failure, but I haven't quite figured out why yet. |
Maybe it only passed because things weren’t fully working before. |
Though I suppose that test is now timing out so that's probably not correct. |
Ok I'm not sure what's happening inside Glide, but the load does actually take this long to fail. I was setting breakpoints in the java code, and from calling |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
I think the main fix here is using the builder with caching was not retaining the correct builder instance in those cases, this fixes the logic.
fixes #6231
fixes #6228
fixes #6363
fixes #6067