[Windows] Fix Border content position and clipping #6472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clip the content
jsuarezruiz
added
t/bug
jsuarezruiz
commented
Apr 25, 2022
| Content.RenderTransform = new TranslateTransform() { X = -strokeThickness, Y = -strokeThickness }; | ||
| } | ||
|
|
||
| void UpdateClip(IShape? borderShape) |
There was a problem hiding this comment.
This is the main change for Clipping.
jsuarezruiz
commented
Apr 25, 2022
|
|
||
| var strokeThickness = _borderPath.StrokeThickness; | ||
|
|
||
| Content.RenderTransform = new TranslateTransform() { X = -strokeThickness, Y = -strokeThickness }; |
There was a problem hiding this comment.
This is the main change to fix the wrong positioning.
|
@jsuarezruiz corner radius on that sample seems broken in this PR |
Thanks for the feedback. Could you review it again? |
Redth
approved these changes
Apr 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR introduce changes in the Windows Border to:
Issues Fixed
Fixes #3471
Fixes #5928