Fix MAUI Blazor crash for multi-window Windows apps #6516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MackinnonBuck
commented
Apr 26, 2022
src/BlazorWebView/src/Maui/PublicAPI/net6.0-windows10.0.19041/PublicAPI.Unshipped.txt
Show resolved
Hide resolved
Eilon
reviewed
Apr 28, 2022
mattleibow
approved these changes
Apr 29, 2022
jsuarezruiz
approved these changes
Apr 29, 2022
MackinnonBuck
deleted the
mbuck/fix-blazorwebview-multi-window-maui-windows
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
There is currently a WinUI 3 bug causing the
WebView2control to throw an exception when its parent window is closed. This primarily affects multi-window scenarios. This PR introduces a workaround to prevent MAUI Windows apps from crashing when a window hosting aBlazorWebViewcontrol is closed.Issues Fixed
Fixes #5722