Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start making everything nullable so we can unset and use defaults #663

Closed
wants to merge 3 commits into from

Conversation

mattleibow
Copy link
Member

Description of Change

Implements #

Additions made

  • Adds

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might effect accessibility?

  • APIs that modify focusability?
  • APIs that modify any text property on a control?
  • Does this PR modify view nesting or view arragement in anyway?
  • Is there the smallest possibility that your PR will change accessibility?
  • I'm not sure, please help me

If any of the above checkboxes apply to your PR then the PR will need to provide testing to demonstrate that accessibility still works.

@charlesroddie
Copy link
Contributor

This is a large increase in complexity. And it prejudices Maui towards the Xamarin approach where things looking different per-platform is the default.

It's not needed because whatever this "default" is, someone who wants this "default" value can get it before creating the Maui object.

@PureWeen
Copy link
Member

Decided to go with the exact opposite approach for now :-)
#1485

@PureWeen PureWeen closed this Jun 28, 2021
@mattleibow mattleibow deleted the dev/nullable-things branch April 4, 2022 16:48
@samhouts samhouts added legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter area-controls-activityindicator ActivityIndicator area-controls-button Button, ImageButton area-controls-checkbox CheckBox area-controls-editor Editor area-controls-entry Entry area-controls-frame Frame area-controls-label Label, Span area-controls-picker Picker area-controls-slider Slider area-controls-stepper Stepper area-controls-switch Switch layout-stack platform/android 🤖 platform/iOS 🍎 platform/windows 🪟 labels Jul 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants