[GH-6523] Fix toolbar text color #6765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pictos
commented
May 3, 2022
PureWeen
requested changes
May 3, 2022
…-text-color-fix
PureWeen
reviewed
May 3, 2022
| @@ -46,7 +46,7 @@ internal void UpdateMenu() | |||
| { | |||
| button.SetBinding(AppBarButton.IconProperty, "IconImageSource", _imageSourceIconElementConverter); | |||
| } | |||
| else | |||
| else if (!item.IconImageSource.IsNullOrEmpty()) | |||
There was a problem hiding this comment.
should we add another else here that nulls out the "content" on the button?
There was a problem hiding this comment.
Not sure if I got that, Oh I see now... On Windows can we have both image + text or does one override the other? If we can have both I've to add another else
|
@PureWeen I just tested on my end |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
PureWeen
approved these changes
May 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
On Android and Windows the text color of ToolbarItem doesn't respect the
BarTextColorproperty ofNavigationPage, this PR fix it.Issues Fixed
Fixes #6523