Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show SearchHandler on Windows #6818

Merged
merged 1 commit into from
May 5, 2022
Merged

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented May 4, 2022

The current SearchHandler code wasn't hooked up in the Windows code. This change allows for a Shell page to set the SearchHandler, and it will get shown in the top tab bar when it is set.

Fix #6036

The current SearchHandler code wasn't hooked up in the Windows code. This change allows for a Shell page to set the SearchHandler, and it will get shown in the top tab bar when it is set.

Fix dotnet#6036
@eerhardt eerhardt requested a review from PureWeen May 4, 2022 16:08
@Eilon Eilon added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 4, 2022
@jsuarezruiz jsuarezruiz added the area-controls-shell Shell Navigation, Routes, Tabs, Flyout label May 5, 2022
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Redth Redth merged commit 024e896 into dotnet:main May 5, 2022
@eerhardt eerhardt deleted the SearchHandlerWindows branch May 5, 2022 15:31
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout platform/windows 🪟
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The SearchHandler is not rendered on Windows
5 participants