Add default BackgroundColor to controls in Styles #6820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
added
the
legacy-area-controls
rachelkang
added
the
area-templates
|
I see there are some AOT profile changes? |
Comment on lines
-10
to
+11
| <ResourceDictionary Source="Resources/Colors.xaml" /> | ||
| <ResourceDictionary Source="Resources/Styles.xaml" /> | ||
| <ResourceDictionary Source="Resources/Styles/Colors.xaml" /> | ||
| <ResourceDictionary Source="Resources/Styles/Styles.xaml" /> |
There was a problem hiding this comment.
Thanks! This was the thing that broke before when we changed the template.
jonathanpeppers
approved these changes
May 4, 2022
mattleibow
approved these changes
May 4, 2022
jonathanpeppers
added a commit
to jonathanpeppers/maui
that referenced
this pull request
May 4, 2022
In dotnet#6820 Rachel and I noticed that there were quite a few API changes that made the `.aotprofile`'s for MAUI out of date. Looking at the [JIT times report][0] for the .NET Podcast app, I saw a couple we could address: Total (ms) | Self (ms) | Method 2.61 | 2.61 | string:SplitInternal (string,string[],int,System.StringSplitOptions) 1.57 | 1.57 | System.Number:NumberToString (System.Text.ValueStringBuilder&,System.Number/NumberBuffer&,char,int,System.Globalization.NumberFormatInfo) 1.52 | 1.52 | System.Number:TryParseInt32IntegerStyle (System.ReadOnlySpan`1<char>,System.Globalization.NumberStyles,System.Globalization.NumberFormatInfo,int&) I added usage of `string.Split()`, `int.Parse()`, and `int.ToString()` to `CommonMethods.cs`. [0]: https://github.com/xamarin/xamarin-android/blob/main/Documentation/guides/profiling.md#profiling-the-jit-compiler ~~ Results ~~ Testing on a Pixel 5, an average of 10 runs. .NET Podcast app: Average(ms): 796.8 Std Err(ms): 3.47626875319565 Std Dev(ms): 10.992927018972 --- Average(ms): 786.8 Std Err(ms): 2.0591260281974 Std Dev(ms): 6.51152823843988 `dotnet new maui`: Average(ms): 563.7 Std Err(ms): 3.26955654485436 Std Dev(ms): 10.3392456204503 --- Average(ms): 545.3 Std Err(ms): 2.39930545505708 Std Dev(ms): 7.5872700404471
mattleibow
pushed a commit
that referenced
this pull request
May 5, 2022
In #6820 Rachel and I noticed that there were quite a few API changes that made the `.aotprofile`'s for MAUI out of date. Looking at the [JIT times report][0] for the .NET Podcast app, I saw a couple we could address: Total (ms) | Self (ms) | Method 2.61 | 2.61 | string:SplitInternal (string,string[],int,System.StringSplitOptions) 1.57 | 1.57 | System.Number:NumberToString (System.Text.ValueStringBuilder&,System.Number/NumberBuffer&,char,int,System.Globalization.NumberFormatInfo) 1.52 | 1.52 | System.Number:TryParseInt32IntegerStyle (System.ReadOnlySpan`1<char>,System.Globalization.NumberStyles,System.Globalization.NumberFormatInfo,int&) I added usage of `string.Split()`, `int.Parse()`, and `int.ToString()` to `CommonMethods.cs`. [0]: https://github.com/xamarin/xamarin-android/blob/main/Documentation/guides/profiling.md#profiling-the-jit-compiler ~~ Results ~~ Testing on a Pixel 5, an average of 10 runs. .NET Podcast app: Average(ms): 796.8 Std Err(ms): 3.47626875319565 Std Dev(ms): 10.992927018972 --- Average(ms): 786.8 Std Err(ms): 2.0591260281974 Std Dev(ms): 6.51152823843988 `dotnet new maui`: Average(ms): 563.7 Std Err(ms): 3.26955654485436 Std Dev(ms): 10.3392456204503 --- Average(ms): 545.3 Std Err(ms): 2.39930545505708 Std Dev(ms): 7.5872700404471
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Issues Fixed
Fixes #6006