Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Fix setting the initial Value on Slider #6988

Merged
merged 1 commit into from
May 10, 2022
Merged

[Windows] Fix setting the initial Value on Slider #6988

merged 1 commit into from
May 10, 2022

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Fix setting the initial Value on Windows Slider.

image

Issues Fixed

Fixes #6957

@mattleibow mattleibow added this to the 6.0.300 milestone May 10, 2022
Comment on lines -27 to 28
platformView.ValueChanged += OnPlatformValueChanged;
platformView.Loaded += OnPlatformViewLoaded;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this have to move later? Was it overriding the values or something?

@Redth Redth requested a review from rachelkang May 10, 2022 14:27
@Eilon Eilon added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2022
Copy link
Member

@rachelkang rachelkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Redth Redth merged commit cc87014 into main May 10, 2022
@Redth Redth deleted the fix-6957 branch May 10, 2022 16:31
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider value property is ignored on initialization
5 participants