Fix WinUI Modal to work with lack of root panel #7452

PureWeen · 2022-05-24T18:27:03Z

Fix Modal on WinUI so that it can deal with the fact that everything isn't nested inside a panel. The behavior of setting your ContentPage to transparent in order to show the view underneath is still broken. This PR is primarily about fixing the fact that modal is completely broken and then we will restore the behavior of having a transparent overlay in a separate PR.
Add the RootPanel type back in order to maintain ABI compatibility
Fix IWindow.Title so that it will propagate to the currently active custom title

Fixes #7307

PureWeen added 2 commits May 24, 2022 13:17

Fix WinUI Modal to work with new Root

3b24781

- fix modal page button name

07be948

PureWeen requested a review from hartez May 24, 2022 18:27

PureWeen added this to the 6.0.3xx-sr1 milestone May 24, 2022

PureWeen added 2 commits May 24, 2022 15:47

Update ModalPage.xaml

ab858e1

Update ModalPage.xaml.cs

866fbc1

Eilon added the area-controls-modal label May 24, 2022

jsuarezruiz added the platform/windows 🪟 label May 25, 2022

Redth approved these changes May 25, 2022

View reviewed changes

Redth merged commit 8ce7673 into main May 25, 2022

Redth deleted the fix_winui_modal branch May 25, 2022 17:26

github-actions bot locked and limited conversation to collaborators Dec 21, 2023

Provide feedback