Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolving TableView/ListView issues #7485

Merged
merged 4 commits into from
May 26, 2022
Merged

Resolving TableView/ListView issues #7485

merged 4 commits into from
May 26, 2022

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented May 25, 2022 •
edited

Description of Change

  • When re-attaching the ListView/TableView to the visual tree we need to invalidate the views so that the ListView can return to a functional state. This used to happen naturally in XF because in XF when you navigated back to a page it would force a measure which was basically the same thing as calling InvalidateView
  • A few more fixes related to using a ListView with infinite height

Issues Fixed

Fixes #6584
Fixes #7406
Fixes #6943

@PureWeen PureWeen marked this pull request as ready for review May 26, 2022 09:14
@PureWeen PureWeen added the do-not-merge Don't merge this PR label May 26, 2022
@PureWeen PureWeen mentioned this pull request May 26, 2022
Closed
@Eilon Eilon added the area-controls-listview ListView and TableView label May 26, 2022
@PureWeen PureWeen removed the do-not-merge Don't merge this PR label May 26, 2022
@PureWeen PureWeen merged commit 6537900 into main May 26, 2022
@PureWeen PureWeen deleted the listview_fixes branch May 26, 2022 19:00
This was referenced May 27, 2022
Closed
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@jsuarezruiz jsuarezruiz Awaiting requested review from jsuarezruiz

Assignees
No one assigned
Labels
area-controls-listview ListView and TableView
Projects
None yet
Milestone
No milestone
3 participants
@PureWeen @rmarinho @Eilon